Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Environment] [MAJOR/BREAKING] Authentication overhaul #1606

Closed
wants to merge 1 commit into from

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Jun 26, 2022

Description

Adding support for 2 environments with separate subscriptions and Service Principals for:

  • Deploying validation to a sandbox environment.
  • Publishing template specs and bicep registry to a production environment.
  • ADO - 2 service connections
  • GH - 2 environments

Adding support for using OIDC authentication with GitHub actions, allowing password less auth.

  • Builds on the environment keyword for validation and publication environments.

Pipeline references

Pipeline
Coming soon!

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

* Push updated Readme file(s)

* Fix environement files

* Updated actions to use powershell action in gh

* reset readme

* restore main

* Test login using OCID

* Update all workflows to use Engineering environment :D

* Update workflows to use OIDC

* Added envs to dependency pipeline

* Removing commented out code

* reset global.var and settings

Co-authored-by: CARMLPipelinePrincipal <[email protected]>
@MariusStorhaug MariusStorhaug marked this pull request as draft June 26, 2022 12:15
@MariusStorhaug MariusStorhaug self-assigned this Jun 26, 2022
@MariusStorhaug MariusStorhaug changed the title [MAJOR/BREAKING] OIDC + Dual Environments [MAJOR/BREAKING] Authentication overhaul Jun 26, 2022
@MariusStorhaug MariusStorhaug added documentation Improvements or additions to documentation [cat] pipelines category: pipelines [cat] testing category: testing [cat] publishing category: publishing [cat] github category: GitHub [cat] azure devops category: Azure DevOps labels Jun 26, 2022
@MariusStorhaug MariusStorhaug changed the title [MAJOR/BREAKING] Authentication overhaul [CI framework] [MAJOR/BREAKING] Authentication overhaul Jun 26, 2022
@MariusStorhaug MariusStorhaug changed the title [CI framework] [MAJOR/BREAKING] Authentication overhaul [CI Environment] [MAJOR/BREAKING] Authentication overhaul Jun 26, 2022
@MariusStorhaug MariusStorhaug deleted the issue/1450 branch June 26, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] pipelines category: pipelines [cat] publishing category: publishing [cat] testing category: testing documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant